The following document contains the results of PMD 5.2.3.

Files

org/efaps/admin/access/AccessSet.java

Violation Line
Useless parentheses. 304
Useless parentheses. 358
Useless parentheses. 410
Useless parentheses. 457
Useless parentheses. 614

org/efaps/admin/access/AccessType.java

Violation Line
Useless parentheses. 136
Useless parentheses. 137
Useless parentheses. 138
Useless parentheses. 148
Useless parentheses. 289

org/efaps/admin/common/NumberGenerator.java

Violation Line
Useless parentheses. 440

org/efaps/admin/common/SystemConfiguration.java

Violation Line
Useless parentheses. 644
Useless parentheses. 753

org/efaps/admin/datamodel/Attribute.java

Violation Line
Useless parentheses. 872
Useless parentheses. 967
Useless parentheses. 1000

org/efaps/admin/datamodel/AttributeSet.java

Violation Line
These nested if statements could be combined 204206

org/efaps/admin/datamodel/AttributeType.java

Violation Line
Useless parentheses. 430

org/efaps/admin/datamodel/Dimension.java

Violation Line
Avoid unused constructor parameters such as '_description'. 180
Useless parentheses. 394
Useless parentheses. 468

org/efaps/admin/datamodel/SQLTable.java

Violation Line
Avoid unused constructor parameters such as '_con'. 197
Useless parentheses. 510

org/efaps/admin/datamodel/Status.java

Violation Line
Useless parentheses. 491
Useless parentheses. 552

org/efaps/admin/datamodel/attributetype/AbstractLinkType.java

Violation Line
Useless parentheses. 54
Useless parentheses. 54

org/efaps/admin/datamodel/attributetype/AbstractType.java

Violation Line
Useless parentheses. 124

org/efaps/admin/datamodel/attributetype/BooleanType.java

Violation Line
Useless parentheses. 117
Useless parentheses. 117
Useless parentheses. 132
Useless parentheses. 132

org/efaps/admin/datamodel/attributetype/CompanyLinkType.java

Violation Line
Useless parentheses. 63
Useless parentheses. 63

org/efaps/admin/datamodel/attributetype/ConsortiumLinkType.java

Violation Line
Useless parentheses. 63
Useless parentheses. 63

org/efaps/admin/datamodel/attributetype/DateTimeType.java

Violation Line
Useless parentheses. 128
Useless parentheses. 128
Useless parentheses. 128

org/efaps/admin/datamodel/attributetype/DateType.java

Violation Line
Useless parentheses. 62
Useless parentheses. 62
Useless parentheses. 62

org/efaps/admin/datamodel/attributetype/DecimalType.java

Violation Line
Useless parentheses. 75
Useless parentheses. 75
Useless parentheses. 75
Useless parentheses. 77
Useless parentheses. 77
Useless parentheses. 109
Useless parentheses. 145

org/efaps/admin/datamodel/attributetype/GroupLinkType.java

Violation Line
Useless parentheses. 65
Useless parentheses. 65

org/efaps/admin/datamodel/attributetype/IntegerType.java

Violation Line
Useless parentheses. 70
Useless parentheses. 70

org/efaps/admin/datamodel/attributetype/IntegerWithUoMType.java

Violation Line
Useless parentheses. 82
Useless parentheses. 82
Useless parentheses. 86
Useless parentheses. 86
Useless parentheses. 97
Useless parentheses. 97

org/efaps/admin/datamodel/attributetype/JaxbType.java

Violation Line
Useless parentheses. 76
Useless parentheses. 104
Useless parentheses. 104

org/efaps/admin/datamodel/attributetype/LongType.java

Violation Line
Useless parentheses. 69
Useless parentheses. 69
Useless parentheses. 69
Useless parentheses. 71

org/efaps/admin/datamodel/attributetype/RateType.java

Violation Line
Useless parentheses. 76
Useless parentheses. 76
Useless parentheses. 100
Useless parentheses. 100

org/efaps/admin/datamodel/attributetype/RealType.java

Violation Line
Useless parentheses. 69
Useless parentheses. 69

org/efaps/admin/datamodel/attributetype/StringType.java

Violation Line
Useless parentheses. 69
Useless parentheses. 69
Useless parentheses. 69

org/efaps/admin/datamodel/attributetype/StringWithUoMType.java

Violation Line
Useless parentheses. 71
Useless parentheses. 71
Useless parentheses. 71
Useless parentheses. 75
Useless parentheses. 86
Useless parentheses. 86

org/efaps/admin/datamodel/attributetype/TimeType.java

Violation Line
Useless parentheses. 84
Useless parentheses. 84
Useless parentheses. 84

org/efaps/admin/datamodel/ui/BooleanUI.java

Violation Line
Useless parentheses. 88
Useless parentheses. 92
Useless parentheses. 96
Useless parentheses. 99

org/efaps/admin/datamodel/ui/IUIValue.java

Violation Line
Avoid modifiers which are implied by the context 37
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 41

org/efaps/admin/datamodel/ui/LinkWithRangesUI.java

Violation Line
These nested if statements could be combined 6576
Useless parentheses. 109110
Useless parentheses. 111112

org/efaps/admin/datamodel/ui/StringUI.java

Violation Line
These nested if statements could be combined 180184

org/efaps/admin/datamodel/ui/StringWithUoMUI.java

Violation Line
Useless parentheses. 103
Useless parentheses. 103
These nested if statements could be combined 145148

org/efaps/admin/dbproperty/DBProperties.java

Violation Line
Useless parentheses. 256

org/efaps/admin/runlevel/RunLevel.java

Violation Line
Useless parentheses. 327

org/efaps/admin/ui/AbstractCommand.java

Violation Line
Useless parentheses. 558559
These nested if statements could be combined 570579

org/efaps/admin/ui/AbstractUserInterfaceObject.java

Violation Line
These nested if statements could be combined 267270

org/efaps/admin/user/Association.java

Violation Line
Useless parentheses. 221

org/efaps/admin/user/Company.java

Violation Line
Useless parentheses. 319

org/efaps/admin/user/Consortium.java

Violation Line
Useless parentheses. 348
Useless parentheses. 400

org/efaps/admin/user/Group.java

Violation Line
Useless parentheses. 294
Useless parentheses. 357

org/efaps/admin/user/JAASSystem.java

Violation Line
Useless parentheses. 390
Useless parentheses. 390
Useless parentheses. 404
Useless parentheses. 404
Useless parentheses. 496
Useless parentheses. 496
Useless parentheses. 504
Useless parentheses. 504
Useless parentheses. 529

org/efaps/admin/user/Role.java

Violation Line
Useless parentheses. 326
Useless parentheses. 383

org/efaps/beans/ValueList.java

Violation Line
Useless parentheses. 188

org/efaps/bpm/BPM.java

Violation Line
Avoid empty if statements 426431
Avoid empty if statements 454459

org/efaps/bpm/identity/UserGroupCallbackImpl.java

Violation Line
Unnecessary use of fully qualified name 'org.efaps.admin.user.Person.get' due to existing import 'org.efaps.admin.user.Person' 89
Unnecessary use of fully qualified name 'org.efaps.admin.user.Role.get' due to existing import 'org.efaps.admin.user.Role' 114
Unnecessary use of fully qualified name 'org.efaps.admin.user.Person.get' due to existing import 'org.efaps.admin.user.Person' 144
Unnecessary use of fully qualified name 'org.efaps.admin.user.Person.get' due to existing import 'org.efaps.admin.user.Person' 146
Unnecessary use of fully qualified name 'org.efaps.admin.user.Role.get' due to existing import 'org.efaps.admin.user.Role' 150

org/efaps/db/Checkin.java

Violation Line
Useless parentheses. 156
Useless parentheses. 156

org/efaps/db/Checkout.java

Violation Line
Useless parentheses. 151
Useless parentheses. 229
Useless parentheses. 229

org/efaps/db/Context.java

Violation Line
Avoid unused constructor parameters such as '_locale'. 306

org/efaps/db/Delete.java

Violation Line
Useless parentheses. 169
Useless parentheses. 178
Useless parentheses. 192

org/efaps/db/Instance.java

Violation Line
Useless parentheses. 129
Useless parentheses. 129
Useless parentheses. 372
Useless parentheses. 372
Useless parentheses. 460
Useless parentheses. 460

org/efaps/db/MultiPrintQuery.java

Violation Line
These nested if statements could be combined 179181

org/efaps/db/PrintQuery.java

Violation Line
These nested if statements could be combined 161163

org/efaps/db/Update.java

Violation Line
Useless parentheses. 451

org/efaps/db/databases/AbstractDatabase.java

Violation Line
Useless parentheses. 1193

org/efaps/db/databases/DerbyDatabase.java

Violation Line
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 519

org/efaps/db/databases/MySQLDatabase.java

Violation Line
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 653

org/efaps/db/databases/OracleDatabase.java

Violation Line
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 186187
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 483
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 740

org/efaps/db/databases/OracleDatabaseWithAutoSequence.java

Violation Line
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 6162

org/efaps/db/databases/PostgreSQLDatabase.java

Violation Line
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 522
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 687

org/efaps/db/databases/information/ForeignKeyInformation.java

Violation Line
Avoid unused private fields such as 'fkName'. 43
Avoid unused private fields such as 'colName'. 48
Avoid unused private fields such as 'refTableName'. 53
Avoid unused private fields such as 'refColName'. 58
Avoid unused private fields such as 'cascadeDelete'. 64

org/efaps/db/print/OneSelect.java

Violation Line
Avoid unused private methods such as 'isMultiple(Object)'. 723

org/efaps/db/print/value/AttributeValueSelect.java

Violation Line
These nested if statements could be combined 137139
These nested if statements could be combined 166169

org/efaps/db/print/value/ClassificationValueSelect.java

Violation Line
These nested if statements could be combined 102110

org/efaps/db/print/value/EsjpValueSelect.java

Violation Line
An empty statement (semicolon) not part of a loop 84

org/efaps/db/print/value/OIDValueSelect.java

Violation Line
These nested if statements could be combined 7781

org/efaps/db/store/Store.java

Violation Line
Avoid unused method parameters such as '_uUID'. 279

org/efaps/db/store/VFSStoreResource.java

Violation Line
Useless parentheses. 428

org/efaps/eql/JSONData.java

Violation Line
Avoid unused private fields such as 'LOG'. 64

org/efaps/init/StartupDatabaseConnection.java

Violation Line
Unnecessary use of fully qualified name 'javax.naming.Context' due to existing import 'javax.naming.Context' 333
Useless parentheses. 444
Useless parentheses. 483
Useless parentheses. 538
Useless parentheses. 541
Unnecessary use of fully qualified name 'javax.naming.Context' due to existing import 'javax.naming.Context' 561

org/efaps/jaas/efaps/GroupPrincipal.java

Violation Line
Ensure you override both equals() and hashCode() 58

org/efaps/jaas/efaps/PersonPrincipal.java

Violation Line
Ensure you override both equals() and hashCode() 59

org/efaps/jaas/efaps/RolePrincipal.java

Violation Line
Ensure you override both equals() and hashCode() 58

org/efaps/jaas/xml/XMLUserLoginModule.java

Violation Line
Useless parentheses. 176
Useless parentheses. 177178
Useless parentheses. 177

org/efaps/jms/JmsHandler.java

Violation Line
These nested if statements could be combined 121205

org/efaps/jms/JmsSession.java

Violation Line
These nested if statements could be combined 144152

org/efaps/update/FileType.java

Violation Line
Avoid unused private fields such as 'EXT2FILETYPE'. 69
Avoid unused private fields such as 'TYPE2FILETYPE'. 74

org/efaps/update/schema/AbstractFileUpdate.java

Violation Line
Useless parentheses. 131
Useless parentheses. 131

org/efaps/update/schema/access/AccessSetUpdate.java

Violation Line
Useless parentheses. 136

org/efaps/update/schema/datamodel/SQLTableUpdate.java

Violation Line
Useless parentheses. 429
Useless parentheses. 706

org/efaps/update/schema/datamodel/StatusGroupUpdate.java

Violation Line
Useless parentheses. 205
Useless parentheses. 205

org/efaps/update/schema/datamodel/TypeUpdate.java

Violation Line
Useless parentheses. 205
Useless parentheses. 218
Useless parentheses. 451
Useless parentheses. 451
Useless parentheses. 743
Useless parentheses. 756
Useless parentheses. 788
Useless parentheses. 788
Useless parentheses. 802
Useless parentheses. 802

org/efaps/update/schema/ui/AbstractCollectionUpdate.java

Violation Line
Useless parentheses. 147
Useless parentheses. 164

org/efaps/update/schema/ui/CommandUpdate.java

Violation Line
Useless parentheses. 190

org/efaps/update/schema/ui/FormUpdate.java

Violation Line
Useless parentheses. 100

org/efaps/util/ChronologyType.java

Violation Line
Avoid unused private fields such as 'KEY2ENUM'. 199

org/efaps/util/DateTimeUtil.java

Violation Line
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 75

org/efaps/util/EFapsException.java

Violation Line
Useless parentheses. 120
Useless parentheses. 120
Useless parentheses. 147
Useless parentheses. 147
Useless parentheses. 174
Useless parentheses. 174

org/efaps/util/cache/AbstractCache.java

Violation Line
Useless parentheses. 187
Useless parentheses. 188
Useless parentheses. 189

org/efaps/util/cache/NoOpCache.java

Violation Line
Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' 491
Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' 493

Back to top

Reflow Maven skin by Andrius Velykis.