FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes	Bugs	Errors	Missing Classes
733	201	0	0

Files

Class	Bugs
org.efaps.admin.AbstractAdminObject	4
org.efaps.admin.AbstractAdminObject$1	1
org.efaps.admin.access.AccessType	1
org.efaps.admin.common.MsgPhrase	2
org.efaps.admin.common.NumberGenerator	1
org.efaps.admin.common.Quartz	1
org.efaps.admin.common.SystemConfiguration	2
org.efaps.admin.datamodel.Attribute	3
org.efaps.admin.datamodel.AttributeSet	1
org.efaps.admin.datamodel.AttributeType	1
org.efaps.admin.datamodel.Classification	3
org.efaps.admin.datamodel.Dimension	1
org.efaps.admin.datamodel.SQLTable	1
org.efaps.admin.datamodel.Type	2
org.efaps.admin.datamodel.attributetype.CompanyLinkType	1
org.efaps.admin.datamodel.attributetype.DateTimeType	1
org.efaps.admin.datamodel.attributetype.DateType	1
org.efaps.admin.datamodel.attributetype.GroupLinkType	1
org.efaps.admin.datamodel.attributetype.IntegerType	1
org.efaps.admin.datamodel.attributetype.LongType	1
org.efaps.admin.datamodel.attributetype.PasswordType	2
org.efaps.admin.datamodel.attributetype.PersonLinkType	1
org.efaps.admin.datamodel.ui.DateTimeUI	1
org.efaps.admin.datamodel.ui.DateUI	1
org.efaps.admin.datamodel.ui.FieldValue	1
org.efaps.admin.datamodel.ui.TypeUI	2
org.efaps.admin.datamodel.ui.UIValue	1
org.efaps.admin.dbproperty.DBProperties	4
org.efaps.admin.event.EventDefinition	1
org.efaps.admin.program.bundle.TempFileBundle	2
org.efaps.admin.program.esjp.EFapsClassLoader	4
org.efaps.admin.program.esjp.Listener$1	1
org.efaps.admin.ui.AbstractCommand	1
org.efaps.admin.ui.AbstractUserInterfaceObject	1
org.efaps.admin.ui.field.FieldCommand	1
org.efaps.admin.ui.field.FieldGroup	1
org.efaps.admin.ui.field.FieldHeading	1
org.efaps.admin.ui.field.FieldPicker	1
org.efaps.admin.ui.field.FieldSet	1
org.efaps.admin.ui.field.FieldTable	1
org.efaps.admin.user.AbstractUserObject	1
org.efaps.admin.user.Company	1
org.efaps.admin.user.Consortium	2
org.efaps.admin.user.Group	1
org.efaps.admin.user.JAASSystem	7
org.efaps.admin.user.Person	8
org.efaps.admin.user.Role	1
org.efaps.admin.user.UserAttributesSet$UserAttribute	2
org.efaps.beans.ValueList$Token	1
org.efaps.beans.valueparser.ParseException	3
org.efaps.beans.valueparser.SimpleCharStream	4
org.efaps.beans.valueparser.TokenMgrError	1
org.efaps.beans.valueparser.ValueParser	7
org.efaps.beans.valueparser.ValueParserConstants	1
org.efaps.beans.valueparser.ValueParserTokenManager	7
org.efaps.bpm.BPM	2
org.efaps.bpm.compiler.KnowledgeBuilderFactoryServiceImpl	1
org.efaps.bpm.transaction.ConnectionProvider	1
org.efaps.db.AbstractPrintQuery	2
org.efaps.db.AttributeQuery	3
org.efaps.db.Context	1
org.efaps.db.InstanceQuery	2
org.efaps.db.Update$Value	1
org.efaps.db.databases.AbstractDatabase	6
org.efaps.db.databases.DerbyDatabase	3
org.efaps.db.databases.MySQLDatabase	4
org.efaps.db.databases.OracleDatabase	5
org.efaps.db.databases.PostgreSQLDatabase	3
org.efaps.db.print.LinkFromSelect	3
org.efaps.db.print.LinkToSelectPart	2
org.efaps.db.print.value.ClassificationValueSelect	2
org.efaps.db.print.value.EsjpValueSelect	1
org.efaps.db.store.AbstractStoreResource	4
org.efaps.db.store.JCRStoreResource	1
org.efaps.db.store.JDBCStoreResource	2
org.efaps.db.store.JDBCStoreResource$BlobInputStream	2
org.efaps.db.store.Store	1
org.efaps.db.store.VFSStoreResource	2
org.efaps.db.wrapper.SQLDelete	1
org.efaps.db.wrapper.SQLInsert	1
org.efaps.db.wrapper.SQLUpdate	1
org.efaps.eql.EFapsDiagnostic	1
org.efaps.init.StartupDatabaseConnection	2
org.efaps.jaas.LoginHandler$LoginCallbackHandler	1
org.efaps.jaas.SetPasswordHandler$SetPasswordCallbackHandler	1
org.efaps.jaas.efaps.UserLoginModule$UpdateException	1
org.efaps.jaas.xml.XMLUserLoginModule	1
org.efaps.jms.JmsSession	1
org.efaps.message.MessageStatusHolder$MsgCache	2
org.efaps.rest.Compile	1
org.efaps.rest.Update	3
org.efaps.update.AbstractUpdate$AbstractDefinition$1	1
org.efaps.update.event.Event	1
org.efaps.update.schema.common.MsgPhraseUpdate$Definition	1
org.efaps.update.schema.common.NumberGeneratorUpdate$NumberGeneratorDefinition	1
org.efaps.update.schema.datamodel.SQLTableUpdate$Definition	1
org.efaps.update.schema.datamodel.StatusGroupUpdate$StatusDefintion	1
org.efaps.update.schema.dbproperty.DBPropertiesUpdate	2
org.efaps.update.schema.program.AbstractSourceUpdate	1
org.efaps.update.schema.program.esjp.ESJPCompiler$ErrorWriter	1
org.efaps.update.schema.program.jasperreport.JasperGroovyCompiler	1
org.efaps.update.schema.program.staticsource.AbstractStaticSourceCompiler	1
org.efaps.update.schema.program.staticsource.JavaScriptCompiler	1
org.efaps.update.schema.ui.CommandUpdate	1
org.efaps.update.schema.ui.MenuUpdate	1
org.efaps.update.version.ApplicationVersion	2
org.efaps.util.DateTimeUtil	2
org.efaps.util.EFapsException	1
org.efaps.util.cache.AbstractAutomaticCache	1
org.efaps.util.cache.AbstractCache	1
org.efaps.util.cache.InfinispanCache	1
org.efaps.util.cache.NoOpCache$DummyIterator	1

org.efaps.admin.AbstractAdminObject

Bug	Category	Details	Line	Priority
org.efaps.admin.AbstractAdminObject.readFromDB4Links() may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	408	Medium
org.efaps.admin.AbstractAdminObject.readFromDB4Links() may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	407	Medium
org.efaps.admin.AbstractAdminObject.readFromDB4Properties() may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	354	Medium
org.efaps.admin.AbstractAdminObject.readFromDB4Properties() may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	352	Medium

org.efaps.admin.AbstractAdminObject$1

Bug	Category	Details	Line	Priority
Primitive is boxed to call Long.compareTo(Long): use Long.compare(long, long) instead	PERFORMANCE	DM_BOXED_PRIMITIVE_FOR_COMPARE	235	High

org.efaps.admin.access.AccessType

Bug	Category	Details	Line	Priority
org.efaps.admin.access.AccessType.hashCode() invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead	PERFORMANCE	DM_NUMBER_CTOR	148	Medium

org.efaps.admin.common.MsgPhrase

Bug	Category	Details	Line	Priority
Class org.efaps.admin.common.MsgPhrase defines non-transient non-serializable instance field arguments	BAD_PRACTICE	SE_BAD_FIELD	Not available	High
Class org.efaps.admin.common.MsgPhrase defines non-transient non-serializable instance field labels	BAD_PRACTICE	SE_BAD_FIELD	Not available	High

org.efaps.admin.common.NumberGenerator

Bug	Category	Details	Line	Priority
Boxing/unboxing to parse a primitive org.efaps.admin.common.NumberGenerator.setVal(String)	PERFORMANCE	DM_BOXED_PRIMITIVE_FOR_PARSING	250	High

org.efaps.admin.common.Quartz

Bug	Category	Details	Line	Priority
Possible null pointer dereference of envCtx in org.efaps.admin.common.Quartz.initialize() on exception path	CORRECTNESS	NP_NULL_ON_SOME_PATH_EXCEPTION	119	Medium

org.efaps.admin.common.SystemConfiguration

Bug	Category	Details	Line	Priority
new org.efaps.admin.common.SystemConfiguration(long, String, String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead	PERFORMANCE	DM_NUMBER_CTOR	201	Medium
org.efaps.admin.common.SystemConfiguration.getValue(String, Map) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead	PERFORMANCE	DM_NUMBER_CTOR	325	Medium

org.efaps.admin.datamodel.Attribute

Bug	Category	Details	Line	Priority
Possible null pointer dereference of className in org.efaps.admin.datamodel.Attribute.add4Type(Type)	CORRECTNESS	NP_NULL_ON_SOME_PATH	971	Medium
Redundant nullcheck of className, which is known to be non-null in org.efaps.admin.datamodel.Attribute.add4Type(Type)	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	967	Medium
Return value of putIfAbsent is ignored, but _attr is reused in org.efaps.admin.datamodel.Attribute.cacheAttribute(Attribute, Type)	MT_CORRECTNESS	RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED	799	High

org.efaps.admin.datamodel.AttributeSet

Bug	Category	Details	Line	Priority
org.efaps.admin.datamodel.AttributeSet doesn't override Type.equals(Object)	STYLE	EQ_DOESNT_OVERRIDE_EQUALS	1	Medium

org.efaps.admin.datamodel.AttributeType

Bug	Category	Details	Line	Priority
Return value of putIfAbsent is ignored, but _role is reused in org.efaps.admin.datamodel.AttributeType.cacheAttributeType(AttributeType)	MT_CORRECTNESS	RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED	366	High

org.efaps.admin.datamodel.Classification

Bug	Category	Details	Line	Priority
org.efaps.admin.datamodel.Classification doesn't override Type.equals(Object)	STYLE	EQ_DOESNT_OVERRIDE_EQUALS	1	Medium
Possible null pointer dereference of Classification.classifiesType in org.efaps.admin.datamodel.Classification.getClassifiesType()	CORRECTNESS	NP_NULL_ON_SOME_PATH	226	Medium
Possible null pointer dereference of Classification.classifyRelation in org.efaps.admin.datamodel.Classification.getClassifyRelationType()	CORRECTNESS	NP_NULL_ON_SOME_PATH	246	Medium

org.efaps.admin.datamodel.Dimension

Bug	Category	Details	Line	Priority
A prepared statement is generated from a nonconstant String in org.efaps.admin.datamodel.Dimension.getDimensionFromDB(String, Object)	SECURITY	SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING	461	High

org.efaps.admin.datamodel.SQLTable

Bug	Category	Details	Line	Priority
Return value of putIfAbsent is ignored, but _sqlTable is reused in org.efaps.admin.datamodel.SQLTable.cacheSQLTable(SQLTable)	MT_CORRECTNESS	RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED	444	High

org.efaps.admin.datamodel.Type

Bug	Category	Details	Line	Priority
org.efaps.admin.datamodel.Type.getTypeFromDB(String, Object) may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	1412	Medium
org.efaps.admin.datamodel.Type.getTypeFromDB(String, Object) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	1410	Medium

org.efaps.admin.datamodel.attributetype.CompanyLinkType

Bug	Category	Details	Line	Priority
Redundant nullcheck of obj, which is known to be non-null in org.efaps.admin.datamodel.attributetype.CompanyLinkType.readValue(Attribute, List)	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	93	Medium

org.efaps.admin.datamodel.attributetype.DateTimeType

Bug	Category	Details	Line	Priority
Redundant nullcheck of localized, which is known to be non-null in org.efaps.admin.datamodel.attributetype.DateTimeType.eval(Object[])	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	144	Medium

org.efaps.admin.datamodel.attributetype.DateType

Bug	Category	Details	Line	Priority
Redundant nullcheck of localized, which is known to be non-null in org.efaps.admin.datamodel.attributetype.DateType.eval(Object[])	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	85	Medium

org.efaps.admin.datamodel.attributetype.GroupLinkType

Bug	Category	Details	Line	Priority
Redundant nullcheck of obj, which is known to be non-null in org.efaps.admin.datamodel.attributetype.GroupLinkType.readValue(Attribute, List)	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	101	Medium

org.efaps.admin.datamodel.attributetype.IntegerType

Bug	Category	Details	Line	Priority
org.efaps.admin.datamodel.attributetype.IntegerType.readValue(Attribute, List) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead	PERFORMANCE	DM_NUMBER_CTOR	100	Medium

org.efaps.admin.datamodel.attributetype.LongType

Bug	Category	Details	Line	Priority
org.efaps.admin.datamodel.attributetype.LongType.readValue(Attribute, List) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead	PERFORMANCE	DM_NUMBER_CTOR	101	Medium

org.efaps.admin.datamodel.attributetype.PasswordType

Bug	Category	Details	Line	Priority
org.efaps.admin.datamodel.attributetype.PasswordType.prepare(AbstractSQLInsertUpdate, Attribute, Object[]) may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	92	Medium
org.efaps.admin.datamodel.attributetype.PasswordType.prepare(AbstractSQLInsertUpdate, Attribute, Object[]) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	91	Medium

org.efaps.admin.datamodel.attributetype.PersonLinkType

Bug	Category	Details	Line	Priority
Redundant nullcheck of obj, which is known to be non-null in org.efaps.admin.datamodel.attributetype.PersonLinkType.readValue(Attribute, List)	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	57	Medium

org.efaps.admin.datamodel.ui.DateTimeUI

Bug	Category	Details	Line	Priority
Possible null pointer dereference of _fieldValue in org.efaps.admin.datamodel.ui.DateTimeUI.getObject4Compare(FieldValue)	CORRECTNESS	NP_NULL_ON_SOME_PATH	97	Medium

org.efaps.admin.datamodel.ui.DateUI

Bug	Category	Details	Line	Priority
Possible null pointer dereference of _fieldValue in org.efaps.admin.datamodel.ui.DateUI.getObject4Compare(FieldValue)	CORRECTNESS	NP_NULL_ON_SOME_PATH	106	Medium

org.efaps.admin.datamodel.ui.FieldValue

Bug	Category	Details	Line	Priority
org.efaps.admin.datamodel.ui.FieldValue defines compareTo(Object) and uses Object.equals()	BAD_PRACTICE	EQ_COMPARETO_USE_OBJECT_EQUALS	440-461	Medium

org.efaps.admin.datamodel.ui.TypeUI

Bug	Category	Details	Line	Priority
Possible null pointer dereference of value in org.efaps.admin.datamodel.ui.TypeUI.compare(FieldValue, FieldValue)	CORRECTNESS	NP_NULL_ON_SOME_PATH	73	Medium
Null passed for non-null parameter of String.compareTo(String) in org.efaps.admin.datamodel.ui.TypeUI.compare(FieldValue, FieldValue)	CORRECTNESS	NP_NULL_PARAM_DEREF	73	Medium

org.efaps.admin.datamodel.ui.UIValue

Bug	Category	Details	Line	Priority
org.efaps.admin.datamodel.ui.UIValue.get(Field, Attribute, Object) uses the same code for two branches	STYLE	DB_DUPLICATE_BRANCHES	146	Medium

org.efaps.admin.dbproperty.DBProperties

Bug	Category	Details	Line	Priority
org.efaps.admin.dbproperty.DBProperties.cacheOnStart() may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	388	Medium
org.efaps.admin.dbproperty.DBProperties.cacheOnStart() may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	387	Medium
org.efaps.admin.dbproperty.DBProperties.getValueFromDB(String, String) may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	329	Medium
org.efaps.admin.dbproperty.DBProperties.getValueFromDB(String, String) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	326	Medium

org.efaps.admin.event.EventDefinition

Bug	Category	Details	Line	Priority
Exception is caught when Exception is not thrown in org.efaps.admin.event.EventDefinition.addEvents(AbstractAdminObject)	STYLE	REC_CATCH_EXCEPTION	301	Medium

org.efaps.admin.program.bundle.TempFileBundle

Bug	Category	Details	Line	Priority
org.efaps.admin.program.bundle.TempFileBundle.setFile(boolean) may fail to clean up java.io.OutputStream on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	201	Medium
Exceptional return value of java.io.File.delete() ignored in org.efaps.admin.program.bundle.TempFileBundle.<static initializer for TempFileBundle>()	BAD_PRACTICE	RV_RETURN_VALUE_IGNORED_BAD_PRACTICE	71	Medium

org.efaps.admin.program.esjp.EFapsClassLoader

Bug	Category	Details	Line	Priority
org.efaps.admin.program.esjp.EFapsClassLoader.getInstance() creates a org.efaps.admin.program.esjp.EFapsClassLoader classloader, which should be performed within a doPrivileged block	MALICIOUS_CODE	DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED	226	Medium
org.efaps.admin.program.esjp.EFapsClassLoader.getOfflineInstance(ClassLoader) creates a org.efaps.admin.program.esjp.EFapsClassLoader classloader, which should be performed within a doPrivileged block	MALICIOUS_CODE	DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED	243	Medium
Incorrect lazy initialization and update of static field org.efaps.admin.program.esjp.EFapsClassLoader.TMPFOLDER in org.efaps.admin.program.esjp.EFapsClassLoader.getTempFolder()	MT_CORRECTNESS	LI_LAZY_INIT_UPDATE_STATIC	192-204	Medium
Exceptional return value of java.io.File.delete() ignored in org.efaps.admin.program.esjp.EFapsClassLoader.getTempFolder()	BAD_PRACTICE	RV_RETURN_VALUE_IGNORED_BAD_PRACTICE	199	Medium

org.efaps.admin.program.esjp.Listener$1

Bug	Category	Details	Line	Priority
Primitive is boxed to call Integer.compareTo(Integer): use Integer.compare(int, int) instead	PERFORMANCE	DM_BOXED_PRIMITIVE_FOR_COMPARE	194	High

org.efaps.admin.ui.AbstractCommand

Bug	Category	Details	Line	Priority
Load of known null value in org.efaps.admin.ui.AbstractCommand.getTargetMenu()	STYLE	NP_LOAD_OF_KNOWN_NULL_VALUE	560	Medium

org.efaps.admin.ui.AbstractUserInterfaceObject

Bug	Category	Details	Line	Priority
Return value of putIfAbsent is ignored, but _object is reused in org.efaps.admin.ui.AbstractUserInterfaceObject.cacheUIObject(AbstractUserInterfaceObject)	MT_CORRECTNESS	RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED	417	High

org.efaps.admin.ui.field.FieldCommand

Bug	Category	Details	Line	Priority
org.efaps.admin.ui.field.FieldCommand doesn't override Field.equals(Object)	STYLE	EQ_DOESNT_OVERRIDE_EQUALS	1	Medium

org.efaps.admin.ui.field.FieldGroup

Bug	Category	Details	Line	Priority
org.efaps.admin.ui.field.FieldGroup doesn't override Field.equals(Object)	STYLE	EQ_DOESNT_OVERRIDE_EQUALS	1	Medium

org.efaps.admin.ui.field.FieldHeading

Bug	Category	Details	Line	Priority
org.efaps.admin.ui.field.FieldHeading doesn't override Field.equals(Object)	STYLE	EQ_DOESNT_OVERRIDE_EQUALS	1	Medium

org.efaps.admin.ui.field.FieldPicker

Bug	Category	Details	Line	Priority
org.efaps.admin.ui.field.FieldPicker doesn't override Field.equals(Object)	STYLE	EQ_DOESNT_OVERRIDE_EQUALS	1	Medium

org.efaps.admin.ui.field.FieldSet

Bug	Category	Details	Line	Priority
org.efaps.admin.ui.field.FieldSet doesn't override Field.equals(Object)	STYLE	EQ_DOESNT_OVERRIDE_EQUALS	1	Medium

org.efaps.admin.ui.field.FieldTable

Bug	Category	Details	Line	Priority
org.efaps.admin.ui.field.FieldTable doesn't override Field.equals(Object)	STYLE	EQ_DOESNT_OVERRIDE_EQUALS	1	Medium

org.efaps.admin.user.AbstractUserObject

Bug	Category	Details	Line	Priority
org.efaps.admin.user.AbstractUserObject.assignToUserObjectInDb(Type, JAASSystem, AbstractUserObject) passes a nonconstant String to an execute or addBatch method on an SQL statement	SECURITY	SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE	229	Medium

org.efaps.admin.user.Company

Bug	Category	Details	Line	Priority
Return value of putIfAbsent is ignored, but _role is reused in org.efaps.admin.user.Company.cacheCompany(Company)	MT_CORRECTNESS	RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED	268	High

org.efaps.admin.user.Consortium

Bug	Category	Details	Line	Priority
Nullcheck of company at line 388 of value previously dereferenced in org.efaps.admin.user.Consortium.getCompanyRelationFromDB()	CORRECTNESS	RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE	388	Medium
Return value of putIfAbsent is ignored, but _consortium is reused in org.efaps.admin.user.Consortium.cacheConsortium(Consortium)	MT_CORRECTNESS	RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED	291	High

org.efaps.admin.user.Group

Bug	Category	Details	Line	Priority
Possible null pointer dereference of stmt in org.efaps.admin.user.Group.getWithJAASKey(JAASSystem, String) on exception path	CORRECTNESS	NP_NULL_ON_SOME_PATH_EXCEPTION	287	Medium

org.efaps.admin.user.JAASSystem

Bug	Category	Details	Line	Priority
Possible null pointer dereference of ret in org.efaps.admin.user.JAASSystem.getMethod(Class, String, String, String, long) on exception path	CORRECTNESS	NP_NULL_ON_SOME_PATH_EXCEPTION	400	Medium
Return value of putIfAbsent is ignored, but _group is reused in org.efaps.admin.user.JAASSystem.cacheJAASSystem(JAASSystem)	MT_CORRECTNESS	RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED	420	High
Class org.efaps.admin.user.JAASSystem defines non-transient non-serializable instance field groupMethodKey	BAD_PRACTICE	SE_BAD_FIELD	Not available	Medium
Class org.efaps.admin.user.JAASSystem defines non-transient non-serializable instance field personMethodAttributes	BAD_PRACTICE	SE_BAD_FIELD	Not available	Medium
Class org.efaps.admin.user.JAASSystem defines non-transient non-serializable instance field personMethodKey	BAD_PRACTICE	SE_BAD_FIELD	Not available	Medium
Class org.efaps.admin.user.JAASSystem defines non-transient non-serializable instance field personMethodName	BAD_PRACTICE	SE_BAD_FIELD	Not available	Medium
Class org.efaps.admin.user.JAASSystem defines non-transient non-serializable instance field roleMethodKey	BAD_PRACTICE	SE_BAD_FIELD	Not available	Medium

org.efaps.admin.user.Person

Bug	Category	Details	Line	Priority
org.efaps.admin.user.Person.getPersonFromDB(String, Object) may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	1589	Medium
Return value of putIfAbsent is ignored, but _person is reused in org.efaps.admin.user.Person.cachePerson(Person)	MT_CORRECTNESS	RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED	1559	High
org.efaps.admin.user.Person.readFromDBAttributes() passes a nonconstant String to an execute or addBatch method on an SQL statement	SECURITY	SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE	881	Medium
org.efaps.admin.user.Person.updateFalseLoginDB(int) passes a nonconstant String to an execute or addBatch method on an SQL statement	SECURITY	SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE	777	Medium
org.efaps.admin.user.Person.updateLastLogin() passes a nonconstant String to an execute or addBatch method on an SQL statement	SECURITY	SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE	1363	Medium
A prepared statement is generated from a nonconstant String in org.efaps.admin.user.Person.createPerson(JAASSystem, String, String)	SECURITY	SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING	1728	High
A prepared statement is generated from a nonconstant String in org.efaps.admin.user.Person.commitAttrValuesInDB()	SECURITY	SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING	645	Medium
org.efaps.admin.user.Person.commitAttrValuesInDB() makes inefficient use of keySet iterator instead of entrySet iterator	PERFORMANCE	WMI_WRONG_MAP_ITERATOR	649	Medium

org.efaps.admin.user.Role

Bug	Category	Details	Line	Priority
Possible null pointer dereference of stmt in org.efaps.admin.user.Role.getWithJAASKey(JAASSystem, String) on exception path	CORRECTNESS	NP_NULL_ON_SOME_PATH_EXCEPTION	376	Medium

org.efaps.admin.user.UserAttributesSet$UserAttribute

Bug	Category	Details	Line	Priority
org.efaps.admin.user.UserAttributesSet$UserAttribute is serializable and an inner class	BAD_PRACTICE	SE_INNER_CLASS	371-424	Medium
Should org.efaps.admin.user.UserAttributesSet$UserAttribute be a _static_ inner class?	PERFORMANCE	SIC_INNER_SHOULD_BE_STATIC	371-424	Medium

org.efaps.beans.ValueList$Token

Bug	Category	Details	Line	Priority
Should org.efaps.beans.ValueList$Token be a _static_ inner class?	PERFORMANCE	SIC_INNER_SHOULD_BE_STATIC	217-259	Medium

org.efaps.beans.valueparser.ParseException

Bug	Category	Details	Line	Priority
new org.efaps.beans.valueparser.ParseException(Token, int[][], String[]) may expose internal representation by storing an externally mutable object into ParseException.expectedTokenSequences	MALICIOUS_CODE	EI_EXPOSE_REP2	36	Medium
new org.efaps.beans.valueparser.ParseException(Token, int[][], String[]) may expose internal representation by storing an externally mutable object into ParseException.tokenImage	MALICIOUS_CODE	EI_EXPOSE_REP2	37	Medium
org.efaps.beans.valueparser.ParseException.initialise(Token, int[][], String[]) concatenates strings using + in a loop	PERFORMANCE	SBSC_USE_STRINGBUFFER_CONCATENATION	117	Medium

org.efaps.beans.valueparser.SimpleCharStream

Bug	Category	Details	Line	Priority
Found reliance on default encoding in new org.efaps.beans.valueparser.SimpleCharStream(InputStream, int, int, int): new java.io.InputStreamReader(InputStream)	I18N	DM_DEFAULT_ENCODING	322	High
Found reliance on default encoding in new org.efaps.beans.valueparser.SimpleCharStream(InputStream, String, int, int, int): new java.io.InputStreamReader(InputStream)	I18N	DM_DEFAULT_ENCODING	315	High
Found reliance on default encoding in org.efaps.beans.valueparser.SimpleCharStream.ReInit(InputStream, int, int, int): new java.io.InputStreamReader(InputStream)	I18N	DM_DEFAULT_ENCODING	362	High
Found reliance on default encoding in org.efaps.beans.valueparser.SimpleCharStream.ReInit(InputStream, String, int, int, int): new java.io.InputStreamReader(InputStream)	I18N	DM_DEFAULT_ENCODING	355	High

org.efaps.beans.valueparser.TokenMgrError

Bug	Category	Details	Line	Priority
The method name org.efaps.beans.valueparser.TokenMgrError.LexicalError(boolean, int, int, int, String, char) doesn't start with a lower case letter	BAD_PRACTICE	NM_METHOD_NAMING_CONVENTION	108	Medium

org.efaps.beans.valueparser.ValueParser

Bug	Category	Details	Line	Priority
The method name org.efaps.beans.valueparser.ValueParser.AttrValueExpression() doesn't start with a lower case letter	BAD_PRACTICE	NM_METHOD_NAMING_CONVENTION	114-117	Medium
The method name org.efaps.beans.valueparser.ValueParser.AttrValueString() doesn't start with a lower case letter	BAD_PRACTICE	NM_METHOD_NAMING_CONVENTION	107-108	Medium
The method name org.efaps.beans.valueparser.ValueParser.ExpressionString() doesn't start with a lower case letter	BAD_PRACTICE	NM_METHOD_NAMING_CONVENTION	74-101	Medium
The method name org.efaps.beans.valueparser.ValueParser.ReInit(InputStream) doesn't start with a lower case letter	BAD_PRACTICE	NM_METHOD_NAMING_CONVENTION	155-156	Medium
The method name org.efaps.beans.valueparser.ValueParser.ReInit(InputStream, String) doesn't start with a lower case letter	BAD_PRACTICE	NM_METHOD_NAMING_CONVENTION	159-165	Medium
The method name org.efaps.beans.valueparser.ValueParser.ReInit(Reader) doesn't start with a lower case letter	BAD_PRACTICE	NM_METHOD_NAMING_CONVENTION	179-185	Medium
The method name org.efaps.beans.valueparser.ValueParser.ReInit(ValueParserTokenManager) doesn't start with a lower case letter	BAD_PRACTICE	NM_METHOD_NAMING_CONVENTION	198-203	Medium

org.efaps.beans.valueparser.ValueParserConstants

Bug	Category	Details	Line	Priority
org.efaps.beans.valueparser.ValueParserConstants.tokenImage should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	32	Medium

org.efaps.beans.valueparser.ValueParserTokenManager

Bug	Category	Details	Line	Priority
org.efaps.beans.valueparser.ValueParserTokenManager.jjnewLexState should be package protected	MALICIOUS_CODE	MS_PKGPROTECT	365	Medium
org.efaps.beans.valueparser.ValueParserTokenManager.jjstrLiteralImages should be package protected	MALICIOUS_CODE	MS_PKGPROTECT	355	Medium
The method name org.efaps.beans.valueparser.ValueParserTokenManager.ReInit(SimpleCharStream) doesn't start with a lower case letter	BAD_PRACTICE	NM_METHOD_NAMING_CONVENTION	394-398	Medium
The method name org.efaps.beans.valueparser.ValueParserTokenManager.ReInit(SimpleCharStream, int) doesn't start with a lower case letter	BAD_PRACTICE	NM_METHOD_NAMING_CONVENTION	410-412	Medium
The method name org.efaps.beans.valueparser.ValueParserTokenManager.SwitchTo(int) doesn't start with a lower case letter	BAD_PRACTICE	NM_METHOD_NAMING_CONVENTION	417-421	Medium
Switch statement found in org.efaps.beans.valueparser.ValueParserTokenManager.getNextToken() where default case is missing	STYLE	SF_SWITCH_NO_DEFAULT	474-489	Medium
Unread public/protected field: org.efaps.beans.valueparser.ValueParserTokenManager.debugStream	STYLE	URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD	13	Medium

org.efaps.bpm.BPM

Bug	Category	Details	Line	Priority
Incorrect lazy initialization of static field org.efaps.bpm.BPM.PMANAGER in org.efaps.bpm.BPM.initialize()	MT_CORRECTNESS	LI_LAZY_INIT_STATIC	160-221	Medium
Incorrect lazy initialization of static field org.efaps.bpm.BPM.SMANAGER in org.efaps.bpm.BPM.initialize()	MT_CORRECTNESS	LI_LAZY_INIT_STATIC	164-222	Medium

org.efaps.bpm.compiler.KnowledgeBuilderFactoryServiceImpl

Bug	Category	Details	Line	Priority
The class name org.efaps.bpm.compiler.KnowledgeBuilderFactoryServiceImpl shadows the simple name of the superclass org.drools.compiler.builder.impl.KnowledgeBuilderFactoryServiceImpl	BAD_PRACTICE	NM_SAME_SIMPLE_NAME_AS_SUPERCLASS	42-69	High

org.efaps.bpm.transaction.ConnectionProvider

Bug	Category	Details	Line	Priority
Class org.efaps.bpm.transaction.ConnectionProvider defines non-transient non-serializable instance field connectionResource	BAD_PRACTICE	SE_BAD_FIELD	Not available	Medium

org.efaps.db.AbstractPrintQuery

Bug	Category	Details	Line	Priority
org.efaps.db.AbstractPrintQuery.executeOneCompleteStmt(String, List) may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	852	Medium
org.efaps.db.AbstractPrintQuery.executeOneCompleteStmt(String, List) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	851	Medium

org.efaps.db.AttributeQuery

Bug	Category	Details	Line	Priority
org.efaps.db.AttributeQuery.executeOneCompleteStmt(String) may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	216	Medium
org.efaps.db.AttributeQuery.executeOneCompleteStmt(String) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	214	Medium
Return value of new java.util.ArrayList() ignored, but method has no side effect	STYLE	RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT	217	Medium

org.efaps.db.Context

Bug	Category	Details	Line	Priority
org.efaps.db.Context.finalize() is public; should be protected	MALICIOUS_CODE	FI_PUBLIC_SHOULD_BE_PROTECTED	346-357	Medium

org.efaps.db.InstanceQuery

Bug	Category	Details	Line	Priority
org.efaps.db.InstanceQuery.executeOneCompleteStmt(String) may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	146	Medium
org.efaps.db.InstanceQuery.executeOneCompleteStmt(String) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	144	Medium

org.efaps.db.Update$Value

Bug	Category	Details	Line	Priority
org.efaps.db.Update$Value.getValues() may expose internal representation by returning Update$Value.values	MALICIOUS_CODE	EI_EXPOSE_REP	682	Medium

org.efaps.db.databases.AbstractDatabase

Bug	Category	Details	Line	Priority
org.efaps.db.databases.AbstractDatabase.initTableInfo(Connection, String, Map) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	1185	Medium
org.efaps.db.databases.AbstractDatabase.initTableInfoColumns(Connection, String, Map) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	1240	Medium
org.efaps.db.databases.AbstractDatabase.initTableInfoForeignKeys(Connection, String, Map) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	1365	Medium
org.efaps.db.databases.AbstractDatabase.initTableInfoUniqueKeys(Connection, String, Map) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	1304	Medium
org.efaps.db.databases.AbstractDatabase.addTableColumn(Connection, String, String, AbstractDatabase$ColumnType, String, int, int) passes a nonconstant String to an execute or addBatch method on an SQL statement	SECURITY	SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE	713	Medium
org.efaps.db.databases.AbstractDatabase.updateColumn(Connection, String, String, AbstractDatabase$ColumnType, int, int) passes a nonconstant String to an execute or addBatch method on an SQL statement	SECURITY	SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE	821	Medium

org.efaps.db.databases.DerbyDatabase

Bug	Category	Details	Line	Priority
org.efaps.db.databases.DerbyDatabase.check4NullValues(Connection, String, String) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	518	Medium
org.efaps.db.databases.DerbyDatabase.deleteAll(Connection) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	166	Medium
org.efaps.db.databases.DerbyDatabase.createTable(Connection, String) passes a nonconstant String to an execute or addBatch method on an SQL statement	SECURITY	SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE	264	Medium

org.efaps.db.databases.MySQLDatabase

Bug	Category	Details	Line	Priority
org.efaps.db.databases.MySQLDatabase.deleteView(Connection, String) may fail to clean up java.sql.Statement	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION	251	Medium
org.efaps.db.databases.MySQLDatabase.check4NullValues(Connection, String, String) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	652	Medium
org.efaps.db.databases.MySQLDatabase.deleteAll(Connection) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	191	Medium
org.efaps.db.databases.MySQLDatabase.createTable(Connection, String) passes a nonconstant String to an execute or addBatch method on an SQL statement	SECURITY	SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE	281	Medium

org.efaps.db.databases.OracleDatabase

Bug	Category	Details	Line	Priority
org.efaps.db.databases.OracleDatabase.deleteView(Connection, String) may fail to clean up java.sql.Statement	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION	319	Medium
org.efaps.db.databases.OracleDatabase.check4NullValues(Connection, String, String) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	739	Medium
org.efaps.db.databases.OracleDatabase.deleteAll(Connection) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	260	Medium
org.efaps.db.databases.OracleDatabase.initTableInfoColumns(Connection, String, Map) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	586	Medium
org.efaps.db.databases.OracleDatabase.createTable(Connection, String) passes a nonconstant String to an execute or addBatch method on an SQL statement	SECURITY	SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE	364	Medium

org.efaps.db.databases.PostgreSQLDatabase

Bug	Category	Details	Line	Priority
org.efaps.db.databases.PostgreSQLDatabase.check4NullValues(Connection, String, String) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	686	Medium
org.efaps.db.databases.PostgreSQLDatabase.deleteAll(Connection) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	252	Medium
org.efaps.db.databases.PostgreSQLDatabase.createTable(Connection, String) passes a nonconstant String to an execute or addBatch method on an SQL statement	SECURITY	SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE	343	Medium

org.efaps.db.print.LinkFromSelect

Bug	Category	Details	Line	Priority
Possible null pointer dereference of attr in org.efaps.db.print.LinkFromSelect.createSQLStatement(OneSelect)	CORRECTNESS	NP_NULL_ON_SOME_PATH	187	High
org.efaps.db.print.LinkFromSelect.executeOneCompleteStmt(String, List) may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	298	Medium
org.efaps.db.print.LinkFromSelect.executeOneCompleteStmt(String, List) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	296	Medium

org.efaps.db.print.LinkToSelectPart

Bug	Category	Details	Line	Priority
Possible null pointer dereference of attr in org.efaps.db.print.LinkToSelectPart.getType()	CORRECTNESS	NP_NULL_ON_SOME_PATH	167	High
Redundant nullcheck of attr, which is known to be non-null in org.efaps.db.print.LinkToSelectPart.join(OneSelect, SQLSelect, int)	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	128	Medium

org.efaps.db.print.value.ClassificationValueSelect

Bug	Category	Details	Line	Priority
org.efaps.db.print.value.ClassificationValueSelect.executeOneCompleteStmt(String, List) may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	273	Medium
org.efaps.db.print.value.ClassificationValueSelect.executeOneCompleteStmt(String, List) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	271	Medium

org.efaps.db.print.value.EsjpValueSelect

Bug	Category	Details	Line	Priority
Possible null pointer dereference of EsjpValueSelect.esjp in org.efaps.db.print.value.EsjpValueSelect.getValue(Object) on exception path	CORRECTNESS	NP_NULL_ON_SOME_PATH_EXCEPTION	118	Medium

org.efaps.db.store.AbstractStoreResource

Bug	Category	Details	Line	Priority
new org.efaps.db.store.AbstractStoreResource() invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead	PERFORMANCE	DM_NUMBER_CTOR	123	Medium
org.efaps.db.store.AbstractStoreResource.insertDefaults() invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead	PERFORMANCE	DM_NUMBER_CTOR	239	Medium
org.efaps.db.store.AbstractStoreResource.getGeneralID(String) may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	317	Medium
org.efaps.db.store.AbstractStoreResource.getGeneralID(String) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	315	Medium

org.efaps.db.store.JCRStoreResource

Bug	Category	Details	Line	Priority
Useless object stored in variable out of method org.efaps.db.store.JCRStoreResource.write(InputStream, long, String)	STYLE	UC_USELESS_OBJECT	233	Medium

org.efaps.db.store.JDBCStoreResource

Bug	Category	Details	Line	Priority
org.efaps.db.store.JDBCStoreResource.read() may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	202	Medium
org.efaps.db.store.JDBCStoreResource.read() may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	197	Medium

org.efaps.db.store.JDBCStoreResource$BlobInputStream

Bug	Category	Details	Line	Priority
org.efaps.db.store.JDBCStoreResource$BlobInputStream.read(byte[]) ignores result of java.io.InputStream.read(byte[])	BAD_PRACTICE	RR_NOT_CHECKED	408	Medium
Should org.efaps.db.store.JDBCStoreResource$BlobInputStream be a _static_ inner class?	PERFORMANCE	SIC_INNER_SHOULD_BE_STATIC	373-424	Medium

org.efaps.db.store.Store

Bug	Category	Details	Line	Priority
Return value of putIfAbsent is ignored, but _store is reused in org.efaps.db.store.Store.cacheStore(Store)	MT_CORRECTNESS	RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED	264	High

org.efaps.db.store.VFSStoreResource

Bug	Category	Details	Line	Priority
org.efaps.db.store.VFSStoreResource.write(InputStream, long, String) may fail to close stream	BAD_PRACTICE	OS_OPEN_STREAM	279	Medium
org.efaps.db.store.VFSStoreResource.write(InputStream, long, String) ignores result of java.io.InputStream.read(byte[], int, int)	BAD_PRACTICE	RR_NOT_CHECKED	300	Medium

org.efaps.db.wrapper.SQLDelete

Bug	Category	Details	Line	Priority
org.efaps.db.wrapper.SQLDelete.execute(Connection) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	92	Medium

org.efaps.db.wrapper.SQLInsert

Bug	Category	Details	Line	Priority
org.efaps.db.wrapper.SQLInsert.execute(Connection) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	155	Medium

org.efaps.db.wrapper.SQLUpdate

Bug	Category	Details	Line	Priority
org.efaps.db.wrapper.SQLUpdate.execute(Connection) may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	135	Medium

org.efaps.eql.EFapsDiagnostic

Bug	Category	Details	Line	Priority
The class name org.efaps.eql.EFapsDiagnostic shadows the simple name of the superclass org.efaps.eql.validation.EFapsDiagnostic	BAD_PRACTICE	NM_SAME_SIMPLE_NAME_AS_SUPERCLASS	47-55	High

org.efaps.init.StartupDatabaseConnection

Bug	Category	Details	Line	Priority
org.efaps.init.StartupDatabaseConnection.startup(String, String) may fail to clean up java.io.InputStream	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION	218	Medium
Redundant nullcheck of dbType, which is known to be non-null in org.efaps.init.StartupDatabaseConnection.configureDBType(Context, String)	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	414	Medium

org.efaps.jaas.LoginHandler$LoginCallbackHandler

Bug	Category	Details	Line	Priority
Should org.efaps.jaas.LoginHandler$LoginCallbackHandler be a _static_ inner class?	PERFORMANCE	SIC_INNER_SHOULD_BE_STATIC	411-447	Medium

org.efaps.jaas.SetPasswordHandler$SetPasswordCallbackHandler

Bug	Category	Details	Line	Priority
Should org.efaps.jaas.SetPasswordHandler$SetPasswordCallbackHandler be a _static_ inner class?	PERFORMANCE	SIC_INNER_SHOULD_BE_STATIC	140-177	Medium

org.efaps.jaas.efaps.UserLoginModule$UpdateException

Bug	Category	Details	Line	Priority
Should org.efaps.jaas.efaps.UserLoginModule$UpdateException be a _static_ inner class?	PERFORMANCE	SIC_INNER_SHOULD_BE_STATIC	281	Medium

org.efaps.jaas.xml.XMLUserLoginModule

Bug	Category	Details	Line	Priority
Redundant nullcheck of password, which is known to be non-null in org.efaps.jaas.xml.XMLUserLoginModule.login()	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	176	Medium

org.efaps.jms.JmsSession

Bug	Category	Details	Line	Priority
context is null guaranteed to be dereferenced in org.efaps.jms.JmsSession.checkLogin(String, String, String) on exception path	CORRECTNESS	NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH	278	Medium

org.efaps.message.MessageStatusHolder$MsgCache

Bug	Category	Details	Line	Priority
org.efaps.message.MessageStatusHolder$MsgCache.update() may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	169	Medium
org.efaps.message.MessageStatusHolder$MsgCache.update() may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	166	Medium

org.efaps.rest.Compile

Bug	Category	Details	Line	Priority
Possible null pointer dereference in org.efaps.rest.Compile.getClassPathElements() due to return value of called method	STYLE	NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE	126	Medium

org.efaps.rest.Update

Bug	Category	Details	Line	Priority
org.efaps.rest.Update.updateFromFile(MultiPart) may fail to clean up java.io.OutputStream on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	95	Medium
Exceptional return value of java.io.File.delete() ignored in org.efaps.rest.Update.updateFromFile(MultiPart)	BAD_PRACTICE	RV_RETURN_VALUE_IGNORED_BAD_PRACTICE	79	Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.efaps.rest.Update.updateFromFile(MultiPart)	BAD_PRACTICE	RV_RETURN_VALUE_IGNORED_BAD_PRACTICE	83	Medium

org.efaps.update.AbstractUpdate$AbstractDefinition$1

Bug	Category	Details	Line	Priority
Primitive is boxed to call Long.compareTo(Long): use Long.compare(long, long) instead	PERFORMANCE	DM_BOXED_PRIMITIVE_FOR_COMPARE	1110	High

org.efaps.update.event.Event

Bug	Category	Details	Line	Priority
Boxing/unboxing to parse a primitive new org.efaps.update.event.Event(String, EventType, String, String, String)	PERFORMANCE	DM_BOXED_PRIMITIVE_FOR_PARSING	108	High

org.efaps.update.schema.common.MsgPhraseUpdate$Definition

Bug	Category	Details	Line	Priority
Boxing/unboxing to parse a primitive org.efaps.update.schema.common.MsgPhraseUpdate$Definition.addArgument(String, String, String, String)	PERFORMANCE	DM_BOXED_PRIMITIVE_FOR_PARSING	147	High

org.efaps.update.schema.common.NumberGeneratorUpdate$NumberGeneratorDefinition

Bug	Category	Details	Line	Priority
Boxing/unboxing to parse a primitive org.efaps.update.schema.common.NumberGeneratorUpdate$NumberGeneratorDefinition.readXML(List, Map, String)	PERFORMANCE	DM_BOXED_PRIMITIVE_FOR_PARSING	88	High

org.efaps.update.schema.datamodel.SQLTableUpdate$Definition

Bug	Category	Details	Line	Priority
org.efaps.update.schema.datamodel.SQLTableUpdate$Definition.executeSQLs() may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	571	Medium

org.efaps.update.schema.datamodel.StatusGroupUpdate$StatusDefintion

Bug	Category	Details	Line	Priority
Should org.efaps.update.schema.datamodel.StatusGroupUpdate$StatusDefintion be a _static_ inner class?	PERFORMANCE	SIC_INNER_SHOULD_BE_STATIC	96-128	Medium

org.efaps.update.schema.dbproperty.DBPropertiesUpdate

Bug	Category	Details	Line	Priority
Possible null pointer dereference of ret in org.efaps.update.schema.dbproperty.DBPropertiesUpdate.insertNewBundle() on exception path	CORRECTNESS	NP_NULL_ON_SOME_PATH_EXCEPTION	215	Medium
Possible null pointer dereference of ret in org.efaps.update.schema.dbproperty.DBPropertiesUpdate.insertNewLanguage(String) on exception path	CORRECTNESS	NP_NULL_ON_SOME_PATH_EXCEPTION	190	Medium

org.efaps.update.schema.program.AbstractSourceUpdate

Bug	Category	Details	Line	Priority
org.efaps.update.schema.program.AbstractSourceUpdate.getVersion() invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead	PERFORMANCE	DM_NUMBER_CTOR	80	Medium

org.efaps.update.schema.program.esjp.ESJPCompiler$ErrorWriter

Bug	Category	Details	Line	Priority
Should org.efaps.update.schema.program.esjp.ESJPCompiler$ErrorWriter be a _static_ inner class?	PERFORMANCE	SIC_INNER_SHOULD_BE_STATIC	318-355	Medium

org.efaps.update.schema.program.jasperreport.JasperGroovyCompiler

Bug	Category	Details	Line	Priority
org.efaps.update.schema.program.jasperreport.JasperGroovyCompiler.compileUnits(JRCompilationUnit[], String, File) creates a groovy.lang.GroovyClassLoader classloader, which should be performed within a doPrivileged block	MALICIOUS_CODE	DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED	94	Medium

org.efaps.update.schema.program.staticsource.AbstractStaticSourceCompiler

Bug	Category	Details	Line	Priority
Null passed for non-null parameter of new java.io.ByteArrayInputStream(byte[]) in org.efaps.update.schema.program.staticsource.AbstractStaticSourceCompiler.compile()	CORRECTNESS	NP_NULL_PARAM_DEREF	120	Medium

org.efaps.update.schema.program.staticsource.JavaScriptCompiler

Bug	Category	Details	Line	Priority
org.efaps.update.schema.program.staticsource.JavaScriptCompiler.getCompiledString(Instance) may fail to close stream	BAD_PRACTICE	OS_OPEN_STREAM	74	Medium

org.efaps.update.schema.ui.CommandUpdate

Bug	Category	Details	Line	Priority
org.efaps.update.schema.ui.CommandUpdate.ALLLINKS is a mutable collection which should be package protected	MALICIOUS_CODE	MS_MUTABLE_COLLECTION_PKGPROTECT	47	Medium

org.efaps.update.schema.ui.MenuUpdate

Bug	Category	Details	Line	Priority
org.efaps.update.schema.ui.MenuUpdate.ALLLINKS is a mutable collection which should be package protected	MALICIOUS_CODE	MS_MUTABLE_COLLECTION_PKGPROTECT	42	Medium

org.efaps.update.version.ApplicationVersion

Bug	Category	Details	Line	Priority
org.efaps.update.version.ApplicationVersion.compareTo(ApplicationVersion) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead	PERFORMANCE	DM_NUMBER_CTOR	274	Medium
org.efaps.update.version.ApplicationVersion defines compareTo(ApplicationVersion) and uses Object.equals()	BAD_PRACTICE	EQ_COMPARETO_USE_OBJECT_EQUALS	274	Medium

org.efaps.util.DateTimeUtil

Bug	Category	Details	Line	Priority
org.efaps.util.DateTimeUtil.getCurrentTimeFromDB() may fail to clean up java.sql.ResultSet on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	75	Medium
org.efaps.util.DateTimeUtil.getCurrentTimeFromDB() may fail to clean up java.sql.Statement on checked exception	EXPERIMENTAL	OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE	74	Medium

org.efaps.util.EFapsException

Bug	Category	Details	Line	Priority
org.efaps.util.EFapsException.getArgs() may expose internal representation by returning EFapsException.args	MALICIOUS_CODE	EI_EXPOSE_REP	216	Medium

org.efaps.util.cache.AbstractAutomaticCache

Bug	Category	Details	Line	Priority
org.efaps.util.cache.AbstractAutomaticCache.get(long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead	PERFORMANCE	DM_NUMBER_CTOR	48	Medium

org.efaps.util.cache.AbstractCache

Bug	Category	Details	Line	Priority
org.efaps.util.cache.AbstractCache.get(long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead	PERFORMANCE	DM_NUMBER_CTOR	112	Medium

org.efaps.util.cache.InfinispanCache

Bug	Category	Details	Line	Priority
Incorrect lazy initialization and update of static field org.efaps.util.cache.InfinispanCache.CACHEINSTANCE in org.efaps.util.cache.InfinispanCache.get()	MT_CORRECTNESS	LI_LAZY_INIT_UPDATE_STATIC	182-189	Medium

org.efaps.util.cache.NoOpCache$DummyIterator

Bug	Category	Details	Line	Priority
org.efaps.util.cache.NoOpCache$DummyIterator.next() can't throw NoSuchElementException	BAD_PRACTICE	IT_NO_SUCH_ELEMENT	526	Medium